The capture app on shadcn/ui (AD #43) — Plan
Status: approved — Nanndish, 2026-11-20 Author: Nanndish Date: 2026-11-20 Decision: AD #43 (
.claude/CLAUDE.md § Architecture Decisions) — the lead, Tharinda, agreed that the capture app follows AD #39 (reported by Nanndish, 2026-11-20). Scope:forge-et-pwa— the shadcn/ui components, the Tailwind stylesheet, the shadcn-only test and its list, and every screen moved over, one PR each. In the harness: the AD rows, this file, and the statements that said the capture app keeps CSS Modules.
Context
AD #39 made shadcn/ui the CRM’s component library on 2026-10-09 and left the capture app undecided
(owed.md). The capture app’s screens still use its own components in forge-et-pwa/src/ui (Button,
Sheet, Notice, Select and the rest), styled with CSS Modules. F36-a to F36-d are done, so no capture-app
feature branch is in flight that a screen move would collide with.
The capture app already draws the CRM’s colours: src/ui/styles/theme-crm.css declares the CRM’s
semantic colour names (--et-primary, --et-muted-foreground, --et-border and the rest) at :root
(F36-a FR-SC3). So the shadcn components can be mapped onto the same names the CRM maps them onto.
What the scan in D-4 finds on origin/main today: 50 screen files in src/features and src/app use
an older component that has a shadcn counterpart or a raw control. The most used are Button, Notice
(the inline message) and Sheet. Re-run the scan rather than trusting the number; it is in the list file.
Decisions
D-1 — The same library and set-up as the CRM. shadcn/ui components on Radix UI in src/ui/shadcn,
styled with Tailwind v4 classes on the --et-* tokens, adapted to the project’s rules
(aria-disabled, the global focus ring, Field wiring, WCAG 2.1 AA). The stylesheet
src/ui/styles/shadcn.css follows the CRM’s: Tailwind’s theme and utilities layers only, never its
global reset; scanning limited by @source to src/ui/shadcn and the folders moved over; Tailwind’s
own colour palette removed (--color-*: initial); light only. The @/ import alias (src/) is added,
because the shadcn components import through it.
D-2 — The components are copied from forge-et-fe, then adapted; they are not byte-shared. The
CRM’s src/ui/shadcn files already carry its fixes (focus handling in dialogs, aria-disabled, the
loop on option lists), so a fresh shadcn add would lose them. Each file is copied with its test. They
are not added to check:shared, because the capture app changes them (D-3); a fix made in one repo is
copied to the other by hand, as theme-crm.css is. A component is copied when the first screen that
needs it moves, not all at once, so nothing unused ships.
D-3 — The capture app’s sizes stay. Every control keeps the capture app’s 44px target size
(design-system §9; the browser gate checks it at phone, tablet and desktop). Where a shadcn component’s
default is smaller (the Button’s h-9, the Input’s h-9, the Checkbox’s 16px box), the copy is changed
so the touch target is at least 44px. The 14px working size stays: shadcn.css maps text-sm onto
type/body, which capture.css already re-values to 14px. Bottom sheets stay bottom sheets: the
capture app’s Sheet and Drawer become shadcn’s Sheet with side="bottom" (no new drawer library).
A date field stays the phone’s own date picker: shadcn’s Input with type="date", not a Calendar.
One behaviour stays too: a busy button is also unavailable (aria-disabled), as the older Button made
it, because iOS VoiceOver barely announces aria-busy and the capture app shows no spinner; the CRM’s
Button sets only aria-busy.
When a screen moves, its older Button props map onto the shadcn Button like this. The defaults differ, so
a moved <Button> with no variant must say variant="outline", or it turns into the filled primary
button.
Older src/ui/Button |
shadcn src/ui/shadcn/button |
|---|---|
no variant (the default is outline) |
variant="outline" |
variant="primary" |
no variant (the default) |
variant="danger" |
variant="destructive" |
variant="ghost" with icon |
variant="ghost" size="icon", the icon as the child; the icon’s colour changes from text-secondary to foreground |
unavailable |
disabled (still aria-disabled, never the disabled attribute) |
busy |
busy |
fullWidth |
className="w-full" |
buttonLinkClass() on a <Link> |
<Button asChild variant="outline"><Link …/></Button> |
The older Notice maps onto the capture app’s Alert (src/ui/shadcn/alert.tsx, copied in row 2). The
Alert keeps the Notice’s colours, spacing and 18px icon; the screen now writes the icon itself. One
difference is on purpose: the Alert centres the icon on the first line of text (from the line height and
the icon size), where the Notice trimmed the text to its cap height (text-box-trim), so the first row
can be up to 3px taller. Until every screen has moved, the same message can show both ways on two screens.
Older src/ui/Notice |
shadcn src/ui/shadcn/alert |
|---|---|
tone="alert" |
<Alert variant="destructive"><AlertIcon /><AlertDescription>…</AlertDescription></Alert> (role alert, the default) |
tone="status" |
<Alert variant="warning" role="status"><InfoIcon /><AlertDescription>…</AlertDescription></Alert> |
action={…} |
role="none" on the Alert, the role on AlertDescription, and the control in <AlertAction>, so the action is not read out with the sentence |
live={false} |
role="none" on the Alert |
tone={message.tone}, chosen at run time |
alertForTone(tone, live) gives the variant, the icon and the role: const look = alertForTone(…), then <Alert variant={look.variant} role={look.role}><look.Icon />…</Alert> (row 7a) |
A raw <input> and the older TextInput map onto the capture app’s Input (src/ui/shadcn/input.tsx, row 2),
44px tall, which takes a surrounding Field’s id, description and invalid state as TextInput does. The older
Textarea maps onto the capture app’s Textarea (src/ui/shadcn/textarea.tsx, row 5) the same way, three rows to
start. Both keep the capture app’s field look, the older components’: radius/md corners and no shadow (row 5
changed the Input from the CRM’s smaller corners and card shadow, which only the development stub sign-in had
shown), so a screen’s fields do not change when they move. Their invalid edge is destructive. Capture’s
photo <input type="file"> is the Input too: it is visually hidden and opened by Choose a Photo, so the
phone’s own picker is all that shows (D-4).
The older Tabs maps onto the capture app’s Tabs (src/ui/shadcn/tabs.tsx, row 5), which draws the tabs as the
CRM’s saved-view tabs (BUG-527, altrium-io/forge-et-pwa#200, carried into the shadcn Tabs by row 6): the warm
track with no outline, each tab at least 44px and sharing the width, the selected tab filled in the primary
button’s colour with its paired text, and TabsCount for a count, whose figures take primary on the selected
tab. Radix moves focus with the arrow keys, Home and End, selection follows focus, and the list hands Tab
to the selected tab. A click selects a tab as well: Radix selects on mousedown only, and a click with no mousedown
before it (element.click(), some assistive technology, the browser specs’ arrangers) would otherwise select
nothing, which the older Tabs never did. TabsCount brings the space before itself, so a tab’s name reads To
Review 3. A switch whose views are not tab panels (Capture’s mode) passes panels={false}, so no tab names a
panel that is not in the page.
Older src/ui/Tabs |
shadcn src/ui/shadcn/tabs |
|---|---|
activeId, onChange |
<Tabs value onValueChange> |
label |
aria-label on <TabsList> |
tabs={[{ id, label, icon, count }]} |
a <TabsTrigger value={id}> each, with <Icon />, <span>{label}</span> and <TabsCount> |
panelId |
<TabsContent value> for each tab (Radix names the panels); with no panels, panels={false} |
data-testid (each tab took <id>-<tab id>) |
data-testid on <TabsList> and on each <TabsTrigger> |
The older Modal maps onto the capture app’s Dialog (src/ui/shadcn/dialog.tsx, copied in row 3), not the
AlertDialog the CRM uses for a question: Radix’s AlertDialog closes as soon as its action is pressed and its
action cannot be busy, while the capture app’s questions stay open while their action runs (Send Now on
Sign Out?). The Dialog keeps the CRM copy’s Radix wiring (rendered only while open, inert behind it, the
focus guards, Option+Tab) and the older Modal’s frame and rules, so the screen does not change: a bordered
card layout/dialog-sm wide; a header whose title sits level with a 44px ✕; a body that scrolls; a footer
on the warm fill under a rule; the ✕ first; no close on a press outside; closeDisabled; initialFocus; and
focus back to the opener (openerControl) or returnFocus. The CRM’s Rev 90 frame is not adopted here: that
would change every capture-app dialog’s look, a decision for a design-system revision of its own.
The whole page behind a Dialog or Sheet is inert and hidden, as the Modal’s native <dialog> made it. Radix hides
the page with the aria-hidden package, which never hides an [aria-live] element and leaves every ancestor of one
unhidden, once, when the dialog opens. So Plan’s polite lead region, holding Switch Campaign and Archive, stayed
reachable by a screen reader behind the campaign sheet; row 8 (altrium-io/forge-et-pwa#207) made the region inert,
which left <main> a scrolling region with nothing focusable in it, and axe refused it (BUG-537). InertWhileOpen
now makes inert and aria-hidden each child of <body> that does not hold the open dialog, is not one of Radix’s
focus guards and is not inert yet (pageBehind), and removes only the marks it set, so what mounts later is covered
too. The CRM’s copy has the live-region gap: BUG-536.
One difference needs its own rule. The Modal was a native <dialog> in the browser’s top layer, so a toast or
the Ready to review notice already open (both popover elements in the top layer) sat under its backdrop.
The Dialog is an ordinary layer, so they would draw over it and could not be pressed. The Dialog therefore hides
every popover open when it opens, until it closes or the popover closes itself (hideOpenPopovers, Nanndish’s
decision on altrium-io/forge-et-pwa#195). A popover that opens after the dialog shows above it, as it did over
the Modal. Row 4 kept the notice a top-layer popover (only its buttons moved). Row 11 moved the toasts to
Sonner, which are no longer popovers but are drawn above every layer, so the rule stays and now hides a showing
toast as well as an open popover (hideOpenPopoversAndToasts). A toast raised while a Dialog or Sheet is open shows
above it and cannot be pressed or announced, as over the Modal; screens that close a sheet first (useToastWhen)
still announce theirs.
Older src/ui/Modal |
shadcn src/ui/shadcn/dialog |
|---|---|
<Modal open onClose …> |
<Dialog open onOpenChange={(next) => { if (!next) onClose(); }}>{open ? <DialogContent forceMount …> : null}</Dialog> |
title |
<DialogHeader><DialogTitle>…</DialogTitle></DialogHeader> |
description |
<DialogDescription> first in <DialogBody> |
children |
the rest of <DialogBody> |
footer |
<DialogFooter>, Cancel first and the main action last |
closeDisabled, initialFocus, returnFocus |
the same props on DialogContent |
data-testid (the ✕ took <id>-close) |
data-testid on DialogContent, and closeTestId for the ✕ |
The older Sheet maps onto the capture app’s Sheet (src/ui/shadcn/sheet.tsx, copied in row 4): the Dialog’s
Radix wiring and helpers, with the older Sheet’s frame, placements and rules, so a screen does not change.
bottom is anchored to the bottom edge below bp/tablet and a centred layout/dialog-sm card from it;
below-header drops from under the shell’s header, leaving the header clear of the scrim. Focus goes to the
title on opening and back to the opener (openerControl) or returnFocus on close. A press outside closes a
below-header sheet only. modalDialogOpen (the notifications feed’s hold on the Ready to review notice)
counts an open shadcn Dialog or Sheet as well as a native <dialog>, which row 3’s Sign Out? Dialog had
slipped past.
Older src/ui/Sheet |
shadcn src/ui/shadcn/sheet |
|---|---|
<Sheet open onClose …> |
<Sheet open onOpenChange={(next) => { if (!next) onClose(); }}>{open ? <SheetContent forceMount …> : null}</Sheet> |
title, titleIcon |
<SheetHeader><SheetTitle>{icon}{title}</SheetTitle></SheetHeader> |
titleAfter |
<SheetHeader after={…}> |
children |
<SheetBody> |
focusableBody |
<SheetBody focusableLabel="{title}: details"> |
footer |
<SheetFooter> |
placement, closeDisabled |
the same props on SheetContent |
fallbackFocus |
returnFocus={() => ref.current} on SheetContent |
data-testid (the ✕ took <id>-close) |
data-testid on SheetContent, and closeTestId for the ✕ |
The older Drawer maps onto the Sheet’s third placement, drawer (row 7b): the full screen below bp/tablet and
a right-hand layout/dialog-sm panel from it, sliding in from the right, as the older Drawer was. The drawer is
named by a heading in its body (aria-labelledby on SheetContent; this Radix version sets aria-labelledby only
from a Radix Title, and gives no warning when there is none), opens with focus on initialFocus (or on itself),
and a press outside closes it. A sheet opened from a page in the drawer is a second Radix dialog stacked over it,
so Esc and a press outside act on the top one only. A drawer and every sheet opened over it move in the same PR:
a Radix sheet cannot open over a native modal <dialog>, which makes everything outside it inert (row 7a’s review).
Older src/ui/Drawer |
shadcn src/ui/shadcn/sheet |
|---|---|
<Drawer open onClose …> |
<Sheet open onOpenChange={(next) => { if (!next) onClose(); }}><SheetContent forceMount placement="drawer" …> |
labelledBy, initialFocus |
aria-labelledby and initialFocus on SheetContent |
eyebrow, actions |
<SheetDrawerHeader eyebrow actions> |
children, bodyLabel |
<SheetBody focusableLabel={bodyLabel}> |
footer |
<SheetFooter>, a bar pinned under the body |
fallbackFocus |
returnFocus={() => ref.current} |
data-testid (the ✕ took <id>-close) |
data-testid on SheetContent, and closeTestId for the ✕ |
The older Select maps onto the capture app’s NativeSelect (src/ui/shadcn/native-select.tsx, row 7b): shadcn’s
styled native <select>, not the CRM’s Radix Select, because on a phone the platform’s own picker is what shows.
It keeps the Input’s field look and 44px height, the capture app’s chevron, the Field wiring, and disabled as
aria-disabled with the opening press and keys refused. options and placeholderOption become
<NativeSelectOption> children, the placeholder first with the value ''.
The older Checkbox maps onto the capture app’s Checkbox (src/ui/shadcn/checkbox.tsx, row 7b), Radix’s
<button role="checkbox">. The button is the whole row, at least 44px tall and the full width, holding the drawn
box and its label, which names it, so the touch target is the row as on the older one (a separate 18px box failed
the 44px check); the box is icon/md square, filled in primary when ticked. onChange(checked) becomes
onCheckedChange, and unavailable becomes disabled (still aria-disabled).
The older RadioGroup maps onto the capture app’s RadioGroup (src/ui/shadcn/radio-group.tsx, row 9), Radix’s
role="radiogroup" of <button role="radio"> items. As the Checkbox, each item is the whole row, at least 44px tall
and the full width, holding the drawn circle (icon/md, its dot in primary when chosen) and its words, which name
it. The CRM copy’s arrow-key rule is kept: an arrow key chooses the item it moves to however briefly it is held. The
group reports a choice only when it differs from the current one, so a held arrow key does not report it twice, as
the CRM’s copy can (owed.md, the F1-e Nits). The group is named by a visible eyebrow (aria-labelledby), not a
<fieldset> legend, so it reads as a radio group, not a group holding one.
Older src/ui/RadioGroup |
shadcn src/ui/shadcn/radio-group |
|---|---|
legend |
a visible eyebrow, its id in aria-labelledby on <RadioGroup> |
value, onChange |
value, onValueChange |
options={[{ value, label, detail, aside }]} |
a <RadioGroupItem value> each, its words as flex items: the label and · detail taking the free width, aside at the end |
data-testid (each radio took <id>-<value>) |
data-testid on <RadioGroup> and on each <RadioGroupItem> |
The older DropdownMenu maps onto the capture app’s DropdownMenu (src/ui/shadcn/dropdown-menu.tsx, row 10b), copied
from the CRM’s with its fixes (modal={false}, the z/menu layer, a disabled item aria-disabled with the press
refused). Different from the CRM: each item is at least 44px with the capture app’s icon/sm icons; a disabled item’s
reason is its accessible description (aria-describedby), as the older menu’s disabledReason; the arrow keys wrap;
a click with no pointer press before it opens the menu too (as the Tabs’ rule, for assistive technology and the
browser specs’ arrangers); and it has no closing animation, so a sheet opened from an item opens with the menu gone.
The menu portals to <body> after a drawer has marked the page, so pageBehind does not make it inert. A sheet
opened from an item gives focus back to the menu’s trigger (fallbackFocus), since the item has gone by then.
Older src/ui/DropdownMenu |
shadcn src/ui/shadcn/dropdown-menu |
|---|---|
label, icon |
the trigger: <DropdownMenuTrigger asChild><Button variant="ghost" size="icon" aria-label={label}>{icon}</Button></DropdownMenuTrigger> |
items={[{ id, label, icon, disabled, disabledReason }]} |
a <DropdownMenuItem> each, with its icon and words, disabled and disabledReason |
onSelect(id) |
onSelect on each item |
data-testid (the menu took <id>-menu, each item <id>-item-<item id>) |
the same test ids on the trigger, the content and each item |
A raw <button> drawn as a row, a card or a text action (the notification row, the Ready to review notice,
Mark All as Read) becomes the shadcn Button with its CSS Module class. The module’s rules are not in a
cascade layer, so they win wherever they set a property; the Button’s justify-center and corner radius are
overridden with justify-start and rounded-none where the module does not set them. The Button’s
transition-colors is kept on these as the shadcn look: a hover fill and the focus ring now fade in over
150 ms, as on every moved control.
Two visible changes come with the shadcn Button and are not yet drawn in pwa-current: a ghost icon
Button’s icon (a dialog’s or sheet’s ✕, the notice’s Dismiss) is foreground where the older one was
text/secondary, and its hover fill is accent where it was surface/hover. The redraw is owed
(.forge/owed.md).
D-4 — A test enforces it, as in the CRM. src/app/shadcnOnly.test.ts and its helper
src/test/shadcnScan.ts are adapted from the CRM’s (design: .forge/design/harness/shadcn-only-check.md).
Only the list of older components differs (REPLACED): Button and buttonLinkClass (its link form,
replaced by <Button asChild>), Checkbox, DateInput, Drawer,
DropdownMenu, Modal, Notice, RadioGroup, Select, Sheet, Tabs, TextInput, Textarea and Toaster, plus the
raw <button>, <input>, <select>, <textarea>, <table> and <dialog>. Every other src/ui
export (Field, StatusIndicator, ScoreRing, TierBadge, AiProvenance, the icons, the toast store’s
functions) has no shadcn counterpart and stays allowed. src/app/shadcnBackfill.json lists what each
file used when the test landed; the list only shrinks; adding an entry is frontend-reviewer’s
decision on that PR. A raw <input type="file"> for the camera or a file upload has no shadcn
counterpart that keeps the native picker; it stays listed until its screen’s PR decides whether
shadcn’s Input with type="file" replaces it.
D-5 — New dependencies, at forge-et-fe’s versions. Approved by Nanndish on 2026-11-20:
radix-ui, class-variance-authority, clsx, tailwind-merge, and, as dev dependencies,
tailwindcss, @tailwindcss/vite and tw-animate-css (the CRM’s open and close animations, which
shadcn.css imports). Sonner, for the toasts, at the CRM’s version 2.0.8, approved by Nanndish on 2026-11-22
for row 11. The icons stay the capture
app’s own src/ui/icons.tsx; lucide-react is not added.
D-6 — The bundle budget is checked on every PR. The set-up raises the entry chunk’s budget from 410
to 440 kB (bundle-budget.json, with the reason in its $comment): the error boundary is in the entry,
and its Button brings tailwind-merge, class-variance-authority, clsx and Radix’s Slot, which every shadcn
component uses. The entry was 390 kB on main before the set-up and 423 kB after. Radix is split per
component, so a screen pays only for what it imports; each PR records pnpm build’s entry and route
chunk sizes before and after. A budget is raised again only as a reviewed change with its reason, never
to make a PR pass. Row 4 raised the entry’s budget from 440 to 480 kB: the bell is in the shell’s header, so
its sheet brings Radix’s Dialog into the entry (423 kB before, 467 kB after), and every shadcn Sheet and
Dialog shares that code (the Settings chunk fell from 46.8 to 6.1 kB). Loading the bell’s sheet lazily was
not taken: the first press on the bell would wait for a fetch on mobile data, and a chunk a deploy pruned
would replace the whole screen with the root route’s reload page (BUG-258), not only the sheet.
Row 11 (Sonner) lowered the entry from 429.01 to 416.31 kB, but only because the build moved the icons
into a chunk the entry loads at startup: everything loaded at startup grew from 523.76 to 558.66 kB raw
(+34.9 kB) and from 166.5 to 175.5 kB gzipped (+9.1 kB), about 17 kB of it Sonner’s bundled stylesheet.
check:bundle measures the entry alone, so it does not show this; a budget on the startup total is owed
(owed.md). Loading Sonner lazily was not taken, for the same reason as the bell’s sheet: the first
toast would wait for a fetch, and a pruned chunk would replace the screen rather than drop one message.
D-7 — One PR per screen, no ticket. As the CRM’s backfill (shadcn-backfill.md, the lead’s
direction of 2026-10-09): branch feature/shadcn-pwa-<screen>, title feat: move the <screen> to shadcn/ui. The PR copies the components its screen needs, moves the screen, removes the screen’s
entries from shadcnBackfill.json, and adds its folder to shadcn.css’s @source lines. A screen should
look the same after its move, except where a shadcn component draws a control differently; any
visible change is redrawn in .forge/design/prototypes/pwa-current/ and its screenshots in the same
delivery (.claude/rules/plans.md § Required Sections), with a design-system revision when a
component’s look changes. Each PR runs pnpm test:record and pnpm e2e:gate --selected, and gets
/forge-review-pr like any app-repo PR.
D-8 — An older component is deleted when nothing uses it. The PR that moves its last screen
deletes the component, its CSS Module and its test, and removes it from REPLACED. Some parts inside
src/ui are built from an older component (SearchBox uses the older Button): such a part is rebuilt
on the shadcn component, inside src/ui, by the PR that moves the first screen using it, and the older
component cannot be deleted before that. Row 6 rebuilt SearchBox’s Clear search on the shadcn Button, and,
having moved their last users, deleted the older Tabs (with its stylesheet and test) and buttonLinkClass, and
took both out of REPLACED. Row 7b moved the older Checkbox’s only user, Convert to Lead, and deleted it. Row 8 moved the last users of
the older Modal (Archive Campaign?) and DateInput (the campaign form’s show dates) and deleted both. Row 9 moved
the older RadioGroup’s only user, Sort and Filter, and deleted it. Row 10b moved the last users of the older Drawer,
Sheet, Select, TextInput, Textarea, DropdownMenu and Notice (the booth drawer, its Archive sheet and the exhibitor
form) and deleted all seven, with the jsdom showModal shim and modalDialogOpen’s native-dialog branch: the app
renders no native <dialog> any more. Row 11 moved the toasts to Sonner (src/ui/shadcn/sonner.tsx, with the
toast store’s showToast and useToastWhen unchanged for callers) and src/ui/CustomerCheckRegion.tsx’s Try
Again, the older Button’s last user, and deleted the older Toaster and Button. REPLACED is now empty: the
shadcn-only test refuses only the raw <button>, <input>, <select>, <textarea>, <table> and <dialog>, and
shadcnBackfill.json is {}. CountBadge, FilterChip and TierBadge are the capture
app’s own parts, not in REPLACED, and stay; a screen PR that finds a shadcn counterpart worth using
for one of them proposes it in its review.
The work, in order
Each row is one PR. A row is done when its files are gone from shadcnBackfill.json and the PR has
merged.
| # | PR | Files (under src/) |
What it replaces | Status |
|---|---|---|---|---|
| 1 | Set-up, and the error pages as the first screen | the set-up: ui/shadcn/button.tsx, ui/styles/shadcn.css, lib/utils.ts, test/shadcnScan.ts, app/shadcnOnly.test.ts, app/shadcnBackfill.json, main.tsx, and outside src/ vite.config.ts, vitest.config.ts, tsconfig.json, .dependency-cruiser.cjs, package.json, CLAUDE.md; the screen: app/AppErrorBoundary.tsx, app/RouteErrorElement.tsx, app/NotFoundRoute.tsx |
Button, raw <button> |
Done — altrium-io/forge-et-pwa#192 |
| 2 | Sign-in and No access | features/auth/* |
Button, Notice, raw <input> (stub sign-in) |
Done — altrium-io/forge-et-pwa#193 |
| 3 | Settings | features/settings/* |
Button, Notice, Modal | Done — altrium-io/forge-et-pwa#195 |
| 4 | Notifications | features/notifications/* |
Button, Sheet, raw <button> |
Done — altrium-io/forge-et-pwa#201 |
| 5 | Capture | features/capture/* |
Button, Notice, Tabs, Textarea, Modal, raw <button> and <input> |
Done — altrium-io/forge-et-pwa#202 |
| 6 | Leads list | features/leads/LeadsRoute.tsx, LeadsSection.tsx, NotSentBanner.tsx |
Tabs, Button, buttonLinkClass, Notice |
Done — altrium-io/forge-et-pwa#203 |
| 7a | The lead’s parts | features/leads/lead/LeadActions.tsx, LeadPhoto.tsx, LeadWriteOutcome.tsx, TextAction.tsx, features/leads/research/* |
Button, Notice, raw <button> |
Done — altrium-io/forge-et-pwa#204 |
| 7b | The lead’s drawer and sheets | features/leads/lead/LeadDrawer.tsx, ConvertSheet.tsx, EditDetailsSheet.tsx, RejectSheet.tsx, and the Sheet of features/leads/research/RemovePersonDialog.tsx |
Drawer, Sheet, Select, TextInput, Textarea, Checkbox, Button, Notice | Done — altrium-io/forge-et-pwa#205 |
| 8 | Plan — the campaign | features/plan/*.tsx |
Sheet, Modal, DateInput, TextInput, Textarea, Button, Notice, raw <button> |
Done — altrium-io/forge-et-pwa#207 |
| 9 | Plan — exhibitors and the upload | features/plan/exhibitors/* except ExhibitorFormSheet.tsx, features/plan/upload/* |
Sheet, RadioGroup, Select, Button, Notice, raw <button> and <input> |
Done — altrium-io/forge-et-pwa#210 |
| 10a | Plan — the booth’s parts | features/plan/booth/BoothResearch.tsx, VisitPanel.tsx |
Button, Notice, Textarea, raw <button> |
Done — altrium-io/forge-et-pwa#211 |
| 10b | Plan — the booth drawer and its sheets | features/plan/booth/BoothDrawer.tsx, ArchiveExhibitorSheet.tsx, features/plan/exhibitors/ExhibitorFormSheet.tsx |
Drawer, DropdownMenu, Sheet, Select, TextInput, Textarea, Button, Notice | Done — altrium-io/forge-et-pwa#212 |
| 11 | Toasts | app/AppLayout.tsx, ui/toast/* |
Toaster → Sonner (approved 2026-11-22) | Done — altrium-io/forge-et-pwa#213 |
The set-up moves one small screen so that the stylesheet, the alias and the test are proved on a real
page, not only on an unused component. Rows 2 to 10 can be taken in any order once row 1 is on main, and by different developers, because
they touch different folders; the order above is the suggested one, smallest first. Two PRs that both
copy the same shadcn component conflict on that file: the second merges main in and keeps one copy.
Row 7 is two PRs, 7a and 7b, so that each stays small enough to review: 7a moves the parts of the lead’s
page that need no new component, and 7b the drawer and its sheets, which need the Sheet’s drawer
placement, NativeSelect and Checkbox. Remove What Was Found? keeps the older Sheet until 7b, because it
opens over the lead drawer, a native modal <dialog>: a Radix sheet portalled to body would be drawn
under the drawer and made inert by it, and Esc would close the drawer. The drawer and every sheet over it
move together. For the same reason the exhibitor form (ExhibitorFormSheet.tsx, Add Exhibitor and Edit
Exhibitor) moves with row 10, not row 9: the booth drawer, still a native modal <dialog> until row 10, opens it
as Edit Exhibitor. The Plan list opens it too, after Add by Hand closes Add Exhibitors, so between rows 9 and
10 a moved Radix sheet closes and the older native sheet opens in its place; the two are never open together.
Row 10 is two PRs for the same reason as row 7: 10a moves the booth page’s parts, which need no new component and
open no sheet, and 10b the booth drawer with every sheet opened over it (Archive, the exhibitor form), which
needs the shadcn DropdownMenu for the drawer’s actions.
Harness changes in the same delivery
.claude/CLAUDE.md: AD #43’s row; AD #39’s last sentence points at it; the Reference Map row for this file. One fresh-context reviewer checks the AD wording before merge (CLAUDE.md § Compounding Engineeringitem 6)..forge/design/architecture-decisions-why.md: AD #43’s reason and sign-off..forge/engagement-log.md: AD #43’s full text in the archive..forge/owed.md: the Whether the capture app follows AD #39 row goes; the token-gap row no longer waits on it..claude/agents/frontend-reviewer.mddimension 23 and.claude/agents/frontend-implementer.md: coverforge-et-pwa..forge/guides/tech-stack-reference.mdand.forge/design/ui/shadcn-backfill.md: no longer say the capture app is undecided..forge/design/ui/design-system.md: a revision recording that the capture app’s controls come from shadcn/ui, with its own sizes (D-3).
Risks
- Visual drift. shadcn’s defaults (borders, radii, shadows) differ from the capture app’s
components.
shadcn.cssmaps radii and type onto the tokens; anything still different shows in the screenshots and is redrawn or corrected in that screen’s PR. - The browser gate. The page checks measure target sizes and contrast; a copied component that
misses D-3 fails them. Run
pnpm e2e:gate --selectedbefore marking each PR ready. - UAT drop 1 (around 30 November). Each screen PR is small and stands alone, so any screen not moved by then stays on its older components with no loss.