Empire Teas CRM — Quality Checklist
What “checked” means on this project.
.claude/CLAUDE.md § Quality Gatesis the rule; this is its checklist form.
Mandatory Gates (every task, no exceptions)
- [ ] Spec review — requirements approved before planning starts
- [ ] Plan review — implementation approach approved before coding begins
- [ ] Check — lint, tests, and build pass (each app repo’s
CLAUDE.md § Common commands; the local record’sTest recordcheck on the PR’s head, set once after the last push: the build record frompython3 scripts/local-build-evidence.pyinforge-et-be, the test record frompnpm test:recordinforge-et-feandforge-et-pwa) - [ ] Diff review — implementation verified against spec and plan
- [ ] Review record —
/forge-review-pr <repo>#<N>on every app-repo PR intomainorrelease/*(Markdown-only and Dependabot-own heads excepted), its safe fixes applied, and re-run as a delta after every later push;Forge reviewis a required check - [ ] Security review — on a security-sensitive app-repo PR (endpoints, permissions or reach, sign-in, sessions, cookies or tokens, owned-record queries, uploads, external calls, secrets or config, untrusted HTML);
/forge-review-prstep 6a runs it - [ ] Browser QA — a PR into
mainruns no full browser gate, but a frontend PR runspnpm e2e:gate --selectedon its final head before it is marked ready, with the line in its test evidence asSelected browser run: …, and runs it again whenmaingains a merge in the same feature area (.forge/design/harness/fewer-nightly-reds.mdR-1, R-2); the nightly full run checks every browser spec at every size onmain, and a red night is fixed before new work starts. A new route or data state has itsPAGE_STATESentry so that run checks it. On a PR intorelease/*inforge-et-feorforge-et-pwa,pnpm e2e:gate --fullpasses on the head before the PR is marked ready (the push that marks it ready goes throughpnpm e2e:gate --full --push), and covers the head again before merging when a later push changed a gate input (.forge/test-strategy.md § Browsers & Viewports) - [ ] Reflect — answer: what worked, what didn’t, what should be updated in the framework
Standing, automated (confirm green — don’t re-decide per task)
- [ ] Dependency-vulnerability scan (supply chain) — Trivy in each app repo’s
Fast lane: reports HIGH/CRITICAL (CVSS ≥ 7.0) on every ready PR without failing it (the dev deploy runs no scan; ECR scans each dev image on push), and stops a UAT or production release on an open finding without an exception (AD #27, AD #38)
Recommended (use when applicable, skip with justification)
- [ ] Adversarial working-diff review —
/forge-pre-pr-reviewon uncommitted work before opening the PR; a direct conversation with Claude as an extra opinion — for complex features and new architectural patterns