source: .forge/checklists/quality-checklist.md · generated — edit the markdown, not this file

Empire Teas CRM — Quality Checklist

What “checked” means on this project. .claude/CLAUDE.md § Quality Gates is the rule; this is its checklist form.

Mandatory Gates (every task, no exceptions)

  • [ ] Spec review — requirements approved before planning starts
  • [ ] Plan review — implementation approach approved before coding begins
  • [ ] Check — lint, tests, and build pass (each app repo’s CLAUDE.md § Common commands; the local record’s Test record check on the PR’s head, set once after the last push: the build record from python3 scripts/local-build-evidence.py in forge-et-be, the test record from pnpm test:record in forge-et-fe and forge-et-pwa)
  • [ ] Diff review — implementation verified against spec and plan
  • [ ] Review record — /forge-review-pr <repo>#<N> on every app-repo PR into main or release/* (Markdown-only and Dependabot-own heads excepted), its safe fixes applied, and re-run as a delta after every later push; Forge review is a required check
  • [ ] Security review — on a security-sensitive app-repo PR (endpoints, permissions or reach, sign-in, sessions, cookies or tokens, owned-record queries, uploads, external calls, secrets or config, untrusted HTML); /forge-review-pr step 6a runs it
  • [ ] Browser QA — a PR into main runs no full browser gate, but a frontend PR runs pnpm e2e:gate --selected on its final head before it is marked ready, with the line in its test evidence as Selected browser run: …, and runs it again when main gains a merge in the same feature area (.forge/design/harness/fewer-nightly-reds.md R-1, R-2); the nightly full run checks every browser spec at every size on main, and a red night is fixed before new work starts. A new route or data state has its PAGE_STATES entry so that run checks it. On a PR into release/* in forge-et-fe or forge-et-pwa, pnpm e2e:gate --full passes on the head before the PR is marked ready (the push that marks it ready goes through pnpm e2e:gate --full --push), and covers the head again before merging when a later push changed a gate input (.forge/test-strategy.md § Browsers & Viewports)
  • [ ] Reflect — answer: what worked, what didn’t, what should be updated in the framework

Standing, automated (confirm green — don’t re-decide per task)

  • [ ] Dependency-vulnerability scan (supply chain) — Trivy in each app repo’s Fast lane: reports HIGH/CRITICAL (CVSS ≥ 7.0) on every ready PR without failing it (the dev deploy runs no scan; ECR scans each dev image on push), and stops a UAT or production release on an open finding without an exception (AD #27, AD #38)
  • [ ] Adversarial working-diff review — /forge-pre-pr-review on uncommitted work before opening the PR; a direct conversation with Claude as an extra opinion — for complex features and new architectural patterns

Generated from .forge/checklists/quality-checklist.md by .claude/lib/render-docs-html.js. Markdown is canonical.